src/heap/incremental-marking.cc - Issue 2552613004: [heap] Ensure finalization of incremental marking even if all allocations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking.cc

Issue 2552613004: [heap] Ensure finalization of incremental marking even if all allocations (Closed)

Patch Set: do mark-compact instead of scavenge if incremental marking needs finalization Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/incremental-marking.cc

diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc

index d3e4b99981d16c60ebee697f22d0834f39e340f6..03a14e61cda3d525ff93d61df81a24069b81bb7d 100644

--- a/src/heap/incremental-marking.cc

+++ b/src/heap/incremental-marking.cc

@@ -1038,7 +1038,7 @@ double IncrementalMarking::AdvanceIncrementalMarking(

remaining_time_in_ms =

deadline_in_ms - heap()->MonotonicallyIncreasingTimeInMs();

} while (remaining_time_in_ms >= kStepSizeInMs && !IsComplete() &&

- !heap()->mark_compact_collector()->marking_deque()->IsEmpty());

+ !heap()->MarkingDequesAreEmpty());

ulan 2016/12/05 21:18:16 Michael: do you approve this change?

return remaining_time_in_ms;

}