Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2552603002: Add tests for MemoryCoordinator::Can{Throttle,Suspend}Renderer() (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for MemoryCoordinator::Can{Throttle,Suspend}Renderer() This is a follow-up CL of crrev.com/2536533002. BUG=670814 Committed: https://crrev.com/55c11e47b4e1ba6b7f20cda3f3947b592e32a6e8 Cr-Commit-Position: refs/heads/master@{#436212}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -19 lines) Patch
M content/browser/memory/memory_coordinator.h View 1 2 chunks +11 lines, -3 lines 0 comments Download
M content/browser/memory/memory_coordinator.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M content/browser/memory/memory_coordinator_browsertest.cc View 2 chunks +45 lines, -8 lines 0 comments Download
M content/browser/memory/memory_coordinator_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
bashi
PTAL https://codereview.chromium.org/2552603002/diff/1/content/browser/memory/memory_coordinator_browsertest.cc File content/browser/memory/memory_coordinator_browsertest.cc (right): https://codereview.chromium.org/2552603002/diff/1/content/browser/memory/memory_coordinator_browsertest.cc#newcode74 content/browser/memory/memory_coordinator_browsertest.cc:74: EXPECT_FALSE(memory_coordinator->CanThrottleRenderer(render_process_id)); Not directly related to this CL but ...
4 years ago (2016-12-05 00:04:19 UTC) #3
bashi
(forgot to add reviewers...) PTAL
4 years ago (2016-12-05 00:12:28 UTC) #5
haraken
LGTM
4 years ago (2016-12-05 01:06:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552603002/20001
4 years ago (2016-12-05 01:32:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 01:44:14 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-05 01:47:02 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55c11e47b4e1ba6b7f20cda3f3947b592e32a6e8
Cr-Commit-Position: refs/heads/master@{#436212}

Powered by Google App Engine
This is Rietveld 408576698