Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2552583002: [promises] Move promise constants to macros.py. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Move promise constants to macros.py. This should recover part of the Bluebird regression caused by sending let/const to TurboFan+Ignition. R=gsathya@chromium.org Committed: https://crrev.com/3b3ede5d5a31541aec7e146b7c9ce2df40a3e56e Cr-Commit-Position: refs/heads/master@{#41467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/js/macros.py View 1 chunk +9 lines, -0 lines 0 comments Download
M src/js/promise.js View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years ago (2016-12-04 14:24:40 UTC) #1
Benedikt Meurer
Hey Sathya, Here's a mitigation for the bluebird regression (sends fewer functions to TF+I). Please ...
4 years ago (2016-12-04 14:25:28 UTC) #4
gsathya
lgtm
4 years ago (2016-12-04 14:31:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552583002/1
4 years ago (2016-12-04 14:32:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-04 15:05:06 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-04 15:05:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b3ede5d5a31541aec7e146b7c9ce2df40a3e56e
Cr-Commit-Position: refs/heads/master@{#41467}

Powered by Google App Engine
This is Rietveld 408576698