Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 2552553002: [DevTools] Don't expand CallStackSidebarPane on pause if it was collapsed (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 else 102 else
103 element.textContent = Common.UIString('%d stack frames are hidden (black -boxed).', this._hiddenCallFrames); 103 element.textContent = Common.UIString('%d stack frames are hidden (black -boxed).', this._hiddenCallFrames);
104 element.createTextChild(' '); 104 element.createTextChild(' ');
105 var showAllLink = element.createChild('span', 'link'); 105 var showAllLink = element.createChild('span', 'link');
106 showAllLink.textContent = Common.UIString('Show'); 106 showAllLink.textContent = Common.UIString('Show');
107 showAllLink.addEventListener('click', this._revealHiddenCallFrames.bind(th is), false); 107 showAllLink.addEventListener('click', this._revealHiddenCallFrames.bind(th is), false);
108 this.element.insertBefore(element, this.element.firstChild); 108 this.element.insertBefore(element, this.element.firstChild);
109 this._hiddenCallFramesMessageElement = element; 109 this._hiddenCallFramesMessageElement = element;
110 } 110 }
111 this._selectNextVisibleCallFrame(0); 111 this._selectNextVisibleCallFrame(0);
112 this.revealView();
113 } 112 }
114 113
115 /** 114 /**
116 * @param {!Array.<!SDK.DebuggerModel.CallFrame>} callFrames 115 * @param {!Array.<!SDK.DebuggerModel.CallFrame>} callFrames
117 * @return {!Array<!Sources.CallStackSidebarPane.CallFrame>} 116 * @return {!Array<!Sources.CallStackSidebarPane.CallFrame>}
118 */ 117 */
119 _callFramesFromDebugger(callFrames) { 118 _callFramesFromDebugger(callFrames) {
120 var callFrameItems = []; 119 var callFrameItems = [];
121 for (var i = 0, n = callFrames.length; i < n; ++i) { 120 for (var i = 0, n = callFrames.length; i < n; ++i) {
122 var callFrame = callFrames[i]; 121 var callFrame = callFrames[i];
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 */ 434 */
436 _update(liveLocation) { 435 _update(liveLocation) {
437 var uiLocation = liveLocation.uiLocation(); 436 var uiLocation = liveLocation.uiLocation();
438 if (!uiLocation) 437 if (!uiLocation)
439 return; 438 return;
440 var text = uiLocation.linkText(); 439 var text = uiLocation.linkText();
441 this.setSubtitle(text.trimMiddle(30)); 440 this.setSubtitle(text.trimMiddle(30));
442 this.subtitleElement.title = text; 441 this.subtitleElement.title = text;
443 } 442 }
444 }; 443 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698