Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2552533002: [extensions] added checks that function is not empty (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
Reviewers:
Devlin
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[extensions] added checks that function is not empty ModuleSystem::GetModuleFunction function can return empty v8::Local<v8::Function> if condition in first if inside of this function is false. Then invocation of any methods on this local object will produce a crash, e.g. crbug.com/657561. BUG=657561 R=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2546853002 Cr-Commit-Position: refs/heads/master@{#435750} (cherry picked from commit dedd489499fb5b7b47fdd29fef13ffaee2f42dcd) Committed: https://chromium.googlesource.com/chromium/src/+/3bfdb9a43a060b4c938331d9e397c97a1f0a6c5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M extensions/renderer/module_system.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kozy
4 years ago (2016-12-03 17:33:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3bfdb9a43a060b4c938331d9e397c97a1f0a6c5d (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698