Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 255253002: fix bitmap shader leak in gm (Closed)

Created:
6 years, 7 months ago by Dominik Grewe
Modified:
6 years, 7 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix bitmap shader leak in gm this was introduced in https://codereview.chromium.org/245963010 this was detected by caryclark@ by examining the result of valgrind on the skia buildbots BUG=skia:1976 Committed: http://code.google.com/p/skia/source/detail?r=14450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M gm/shadertext2.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dominik Grewe
PTAL
6 years, 7 months ago (2014-04-29 19:52:30 UTC) #1
caryclark
lgtm
6 years, 7 months ago (2014-04-29 20:06:17 UTC) #2
Dominik Grewe
The CQ bit was checked by dominikg@chromium.org
6 years, 7 months ago (2014-04-29 21:24:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/255253002/1
6 years, 7 months ago (2014-04-29 21:25:14 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 21:47:01 UTC) #5
Message was sent while issue was closed.
Change committed as 14450

Powered by Google App Engine
This is Rietveld 408576698