Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl

Issue 2552523002: PaymentApp: Remove unncessary comments in PaymentRequestEvent.idl. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
index 4c2cd0fbd821ad1fed8b59ebf077244ef2f0a9a2..802545dbb8773135cf8fdac04e150da2b9d5743e 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl
@@ -9,19 +9,5 @@
Exposed=ServiceWorker
] interface PaymentRequestEvent : ExtendableEvent {
readonly attribute PaymentAppRequestData data;
- // The payment app api spec says that respondWith() should take a union
- // type as follows:
- // - respondWith((Promise<PaymentResponse> or PaymentResponse));
- //
- // But the web-idl spec says that Promise types are not distinguishable
- // with any other type. Also, if we pass PaymentResponse to respondWith(),
- // then it will just be cast to a promise immediately via Promise.resolve().
- //
- // We found existing case here:
- // - https://github.com/w3c/ServiceWorker/issues/724
- //
- // So, we should just use Promise<PaymentResponse> instead of union type.
- // Related spec bug:
- // - https://github.com/w3c/webpayments-payment-apps-api/pull/71
void respondWith(Promise<PaymentResponse> response);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698