Rework SVGViewSpec<->SVGSVGElement integration

Rework SVGViewSpec<->SVGSVGElement integration

This turns SVGViewSpec into a more independent component, by moving
parsing (case) logic into it, and changing adding an accessor interface
on SVGSVGElement that allows access to, and handles invalidation of the
SVGSVGElement's view properties.

The m_useCurrentView is done away with, and instead the code just checks
if there's an SVGViewSpec attached. Naturally this also means that care
needs to be taken to "detach" the old SVGViewSpec when needed.

Committed: https://crrev.com/1f7513d86de98696682b56311a3cd0bd8bb28749
Cr-Commit-Position: refs/heads/master@{#436704}

[fs, 2016-12-03 15:34:04]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-03 15:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 16:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 16:58:04]

Dry run: This issue passed the CQ dry run.

[fs, 2016-12-03 18:03:34]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-12-06 06:23:52]

Removing m_useCurrentView seems much cleaner. Moving the viewSpec management
feels a little odd because m_viewspec is owned by rootElement but ViewSpec.cpp
ends up managing m_viewSpec. Is it necessary to move the initial view setup out
of SVGSVGElement?

[fs, 2016-12-06 10:00:46]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 10:01:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-12-06 10:03:26]

On 2016/12/06 at 06:23:52, pdr wrote:
> Removing m_useCurrentView seems much cleaner. Moving the viewSpec management
feels a little odd because m_viewspec is owned by rootElement but ViewSpec.cpp
ends up managing m_viewSpec. Is it necessary to move the initial view setup out
of SVGSVGElement?

I wanted to avoid spreading out the "knowledge" about the setup (syntax etc),
but it can be moved back (see PS2.)

[commit-bot: I haz the power, 2016-12-06 11:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 11:19:27]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-12-06 19:31:06]

On 2016/12/06 at 10:03:26, fs wrote:
> On 2016/12/06 at 06:23:52, pdr wrote:
> > Removing m_useCurrentView seems much cleaner. Moving the viewSpec management
feels a little odd because m_viewspec is owned by rootElement but ViewSpec.cpp
ends up managing m_viewSpec. Is it necessary to move the initial view setup out
of SVGSVGElement?
> 
> I wanted to avoid spreading out the "knowledge" about the setup (syntax etc),
but it can be moved back (see PS2.)

Thanks! I like this patch. LGTM

[fs, 2016-12-06 19:58:28]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-12-06 19:59:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 20:41:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481054308002090,
"parent_rev": "ea541c47ed27ffee3a1c50d192d6fb9f119b6268", "commit_rev":
"2740f1aa7d7bfc843c34b564bc08f2d0f0e6dc78"}

[commit-bot: I haz the power, 2016-12-06 20:42:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-06 20:43:41]

Description was changed from

==========
Rework SVGViewSpec<->SVGSVGElement integration

This turns SVGViewSpec into a more independent component, by moving
parsing (case) logic into it, and changing adding an accessor interface
on SVGSVGElement that allows access to, and handles invalidation of the
SVGSVGElement's view properties.

The m_useCurrentView is done away with, and instead the code just checks
if there's an SVGViewSpec attached. Naturally this also means that care
needs to be taken to "detach" the old SVGViewSpec when needed.
==========

to

==========
Rework SVGViewSpec<->SVGSVGElement integration

This turns SVGViewSpec into a more independent component, by moving
parsing (case) logic into it, and changing adding an accessor interface
on SVGSVGElement that allows access to, and handles invalidation of the
SVGSVGElement's view properties.

The m_useCurrentView is done away with, and instead the code just checks
if there's an SVGViewSpec attached. Naturally this also means that care
needs to be taken to "detach" the old SVGViewSpec when needed.

Committed: https://crrev.com/1f7513d86de98696682b56311a3cd0bd8bb28749
Cr-Commit-Position: refs/heads/master@{#436704}
==========

[commit-bot: I haz the power, 2016-12-06 20:43:42]

Patchset 2 (id:??) landed as
https://crrev.com/1f7513d86de98696682b56311a3cd0bd8bb28749
Cr-Commit-Position: refs/heads/master@{#436704}