Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: media/blink/video_frame_compositor.h

Issue 2552493002: [Media] Record time it takes to start rendering audio and video (Closed)
Patch Set: Accessing VFC directly from WMPI Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/video_frame_compositor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/video_frame_compositor.h
diff --git a/media/blink/video_frame_compositor.h b/media/blink/video_frame_compositor.h
index 31857c9ee0bd543430d302c5e74e227c9ee39edc..5048c5f5b19429f1e350a9d4c3874c9fdc82cd91 100644
--- a/media/blink/video_frame_compositor.h
+++ b/media/blink/video_frame_compositor.h
@@ -103,6 +103,11 @@ class MEDIA_BLINK_EXPORT VideoFrameCompositor
// PaintSingleFrame() is not also called while stopped.)
base::TimeDelta GetCurrentFrameTimestamp() const;
+ // Called when the video becomes visible with the timestamp.
DaleCurtis 2017/01/05 22:38:43 visible is a bit confusing in this context; instea
whywhat 2017/01/05 23:15:44 s/Timestamp/Time sgtm Re: s/shown/foreground: 1)
DaleCurtis 2017/01/05 23:21:46 Background rendering and SetForegroundTime() would
+ // Used to record the time it takes to process the first frame after that.
+ // Must be called on the compositor thread.
+ void SetShownTimestamp(base::TimeTicks when);
+
void set_tick_clock_for_testing(std::unique_ptr<base::TickClock> tick_clock) {
tick_clock_ = std::move(tick_clock);
}
@@ -157,6 +162,7 @@ class MEDIA_BLINK_EXPORT VideoFrameCompositor
bool new_background_frame_;
base::TimeDelta last_interval_;
base::TimeTicks last_background_render_;
+ base::TimeTicks last_shown_;
// These values are set on the compositor thread, but also read on the media
// thread when the VFC is stopped.
« no previous file with comments | « no previous file | media/blink/video_frame_compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698