Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2342)

Unified Diff: ash/mus/manifest.json

Issue 2552483002: mash: Have chrome set itself as a controller interface for changing volume (Closed)
Patch Set: review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/mojo_interface_factory.cc ('k') | ash/public/interfaces/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/manifest.json
diff --git a/ash/mus/manifest.json b/ash/mus/manifest.json
index ab525538d6842810e17ef4134b7a7501c4264855..c1c74dc8d436f3231a15877ebaf2089a403e4fdb 100644
--- a/ash/mus/manifest.json
+++ b/ash/mus/manifest.json
@@ -4,7 +4,10 @@
"interface_provider_specs": {
"service_manager:connector": {
"provides": {
+ // See also chrome_content_browser_manifest_overlay.json for classic ash
msw 2016/12/06 19:43:57 Hmm, I'm not sure how this comment is helpful? Wha
James Cook 2016/12/06 20:11:53 I'm trying to convey the fact that when you add an
msw 2016/12/06 20:13:29 Maybe explicitly say "Modifications here should co
James Cook 2016/12/06 20:19:15 Yeah, that's better. Done.
+ // when these interfaces are provided by content_browser.
"ash": [
+ "ash::mojom::AcceleratorController",
"ash::mojom::CastConfig",
"ash::mojom::LocaleNotificationController",
"ash::mojom::ShelfController",
« no previous file with comments | « ash/common/mojo_interface_factory.cc ('k') | ash/public/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698