Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5985)

Unified Diff: chrome/browser/ui/views/profiles/user_manager_view.h

Issue 2552473002: Display error message when user try to open a locked supervised user profile when force-sign-in is … (Closed)
Patch Set: sky's comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/user_manager.cc ('k') | chrome/browser/ui/views/profiles/user_manager_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/profiles/user_manager_view.h
diff --git a/chrome/browser/ui/views/profiles/user_manager_view.h b/chrome/browser/ui/views/profiles/user_manager_view.h
index 5ec3fd9436c08fc573f8d7912d42b16abe8f115b..e140aab103dfe40a592d5fd87674d5b591a03a7e 100644
--- a/chrome/browser/ui/views/profiles/user_manager_view.h
+++ b/chrome/browser/ui/views/profiles/user_manager_view.h
@@ -19,27 +19,28 @@
class ScopedKeepAlive;
class UserManagerView;
-class ReauthDelegate : public views::DialogDelegateView,
- public UserManager::BaseReauthDialogDelegate {
+class UserManagerProfileDialogDelegate
+ : public views::DialogDelegateView,
+ public UserManagerProfileDialog::BaseDialogDelegate {
public:
- ReauthDelegate(UserManagerView* parent,
- views::WebView* web_view,
- const std::string& email_address,
- signin_metrics::Reason reason);
- ~ReauthDelegate() override;
+ UserManagerProfileDialogDelegate(UserManagerView* parent,
+ views::WebView* web_view,
+ const std::string& email_address,
+ const GURL& url);
+ ~UserManagerProfileDialogDelegate() override;
- // UserManager::BaseReauthDialogDelegate:
- void CloseReauthDialog() override;
+ // UserManagerProfileDialog::BaseDialogDelegate
+ void CloseDialog() override;
// Display the local error message inside login window.
void DisplayErrorMessage();
private:
- ReauthDelegate();
+ UserManagerProfileDialogDelegate();
// Before its destruction, tells its parent container to reset its reference
- // to the ReauthDelegate.
- void OnReauthDialogDestroyed();
+ // to the UserManagerProfileDialogDelegate.
+ void OnDialogDestroyed();
// views::DialogDelegate:
gfx::Size GetPreferredSize() const override;
@@ -57,7 +58,7 @@ class ReauthDelegate : public views::DialogDelegateView,
views::WebView* web_view_;
const std::string email_address_;
- DISALLOW_COPY_AND_ASSIGN(ReauthDelegate);
+ DISALLOW_COPY_AND_ASSIGN(UserManagerProfileDialogDelegate);
};
namespace views {
@@ -85,20 +86,14 @@ class UserManagerView : public views::DialogDelegateView {
// Logs how long it took the UserManager to open.
void LogTimeToOpen();
- // Shows a dialog where the user can re-authenticate the profile with the
- // given |email|. This is called in the following scenarios:
- // -From the user manager when a profile is locked and the user's password is
- // detected to have been changed.
- // -From the user manager when a custodian account needs to be
- // reauthenticated.
- // reason| can be REASON_UNLOCK or REASON_REAUTHENTICATION to indicate
- // whether this is a reauth or unlock scenario.
- void ShowReauthDialog(content::BrowserContext* browser_context,
- const std::string& email,
- signin_metrics::Reason reason);
-
// Hides the reauth dialog if it is showing.
- void HideReauthDialog();
+ void HideDialog();
+
+ // Show a dialog where the user can auth the profile or see the auth error
+ // message.
+ void ShowDialog(content::BrowserContext* browser_context,
+ const std::string& email,
+ const GURL& url);
// Display sign in error message that is created by Chrome but not GAIA
// without browser window.
@@ -110,13 +105,13 @@ class UserManagerView : public views::DialogDelegateView {
base::FilePath GetSigninProfilePath();
private:
- friend class ReauthDelegate;
+ friend class UserManagerProfileDialogDelegate;
friend std::default_delete<UserManagerView>;
~UserManagerView() override;
// Resets delegate_ to nullptr when delegate_ is no longer alive.
- void OnReauthDialogDestroyed();
+ void OnDialogDestroyed();
// Creates dialog and initializes UI.
void Init(Profile* guest_profile, const GURL& url);
@@ -136,7 +131,7 @@ class UserManagerView : public views::DialogDelegateView {
views::WebView* web_view_;
- ReauthDelegate* delegate_;
+ UserManagerProfileDialogDelegate* delegate_;
std::unique_ptr<ScopedKeepAlive> keep_alive_;
base::Time user_manager_started_showing_;
« no previous file with comments | « chrome/browser/ui/user_manager.cc ('k') | chrome/browser/ui/views/profiles/user_manager_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698