Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2552443002: WebVR: Add sanity checks for decoded pose index values (Closed)

Created:
4 years ago by bajones
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

WebVR: Add sanity checks for decoded pose index values We seem to be getting glitches in the display pipeline that manifest as all-white pixels for a few frames before regular rendering starts. These get misinterpreted as an invalid pose index, and apparently supplying a wrong pose to GVR permanently breaks reprojection for that instance. Add sanity checks to help identify and avoid bad pose values during initialization. BUG=667327 Review-Url: https://codereview.chromium.org/2541023003 Cr-Commit-Position: refs/heads/master@{#435866} (cherry picked from commit 490f4294847d427265ae138de9932926d61b885e) Committed: https://chromium.googlesource.com/chromium/src/+/ff9b716dacc4003878af2122770986ce03f574f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -13 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 5 chunks +54 lines, -11 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bajones
4 years ago (2016-12-02 21:52:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff9b716dacc4003878af2122770986ce03f574f6.

Powered by Google App Engine
This is Rietveld 408576698