Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2552413002: Do not run discardable memory related browser test for official build. (Closed)

Created:
4 years ago by Peng
Modified:
4 years ago
Reviewers:
reveman, jam, Reid Kleckner
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not run discardable memory related browser test for official build. Because chrome official build doesn't support single process mode which is needed by those tests. BUG=671402 Committed: https://crrev.com/41bfe5f32037f987cda7c7a2380aeb3148404d6a Cr-Commit-Position: refs/heads/master@{#437029}

Patch Set 1 #

Patch Set 2 : Fix a build issue #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -108 lines) Patch
M content/renderer/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 chunks +0 lines, -107 lines 0 comments Download
A content/renderer/render_thread_impl_discardable_memory_browsertest.cc View 1 1 chunk +137 lines, -0 lines 2 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
Peng
Hi David, PTAL. Thanks.
4 years ago (2016-12-06 20:34:13 UTC) #3
reveman
https://codereview.chromium.org/2552413002/diff/20001/content/renderer/render_thread_impl_discardable_memory_browsertest.cc File content/renderer/render_thread_impl_discardable_memory_browsertest.cc (right): https://codereview.chromium.org/2552413002/diff/20001/content/renderer/render_thread_impl_discardable_memory_browsertest.cc#newcode63 content/renderer/render_thread_impl_discardable_memory_browsertest.cc:63: IN_PROC_BROWSER_TEST_F(RenderThreadImplDiscardableMemoryBrowserTest, I'm not able to see what changed in ...
4 years ago (2016-12-07 16:40:38 UTC) #9
Peng
https://codereview.chromium.org/2552413002/diff/20001/content/renderer/render_thread_impl_discardable_memory_browsertest.cc File content/renderer/render_thread_impl_discardable_memory_browsertest.cc (right): https://codereview.chromium.org/2552413002/diff/20001/content/renderer/render_thread_impl_discardable_memory_browsertest.cc#newcode63 content/renderer/render_thread_impl_discardable_memory_browsertest.cc:63: IN_PROC_BROWSER_TEST_F(RenderThreadImplDiscardableMemoryBrowserTest, On 2016/12/07 16:40:38, reveman wrote: > I'm not ...
4 years ago (2016-12-07 16:45:45 UTC) #10
reveman
Got it. lgtm.
4 years ago (2016-12-07 17:06:48 UTC) #11
Peng
Hi John, PTAL. Thanks.
4 years ago (2016-12-07 17:10:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552413002/20001
4 years ago (2016-12-07 17:52:40 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/320614)
4 years ago (2016-12-07 18:02:21 UTC) #17
jam
lgtm
4 years ago (2016-12-07 19:17:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552413002/20001
4 years ago (2016-12-07 19:18:45 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 19:29:08 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-07 19:31:12 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41bfe5f32037f987cda7c7a2380aeb3148404d6a
Cr-Commit-Position: refs/heads/master@{#437029}

Powered by Google App Engine
This is Rietveld 408576698