Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2552383007: Re-enable service test on simarm, simmips and simarm64. (Closed)

Created:
4 years ago by Florian Schneider
Modified:
4 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-enable service test on simarm, simmips and simarm64. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/a9bac538cae183596bd75a0babd0b0bd56dabbb5

Patch Set 1 #

Patch Set 2 : skip in debug mode for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/observatory/tests/service/service.status View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
Do you think we can enable these again? The slowest test takes around 1min20s on ...
4 years ago (2016-12-09 17:42:47 UTC) #2
Cutch
LGTM. Let's see how the bots feel about it.
4 years ago (2016-12-09 17:43:19 UTC) #3
Florian Schneider
4 years ago (2016-12-09 17:46:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a9bac538cae183596bd75a0babd0b0bd56dabbb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698