Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2552383006: Revert of Enable hermetic builds for iOS. (Closed)

Created:
4 years ago by justincohen
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable hermetic builds for iOS. (patchset #4 id:100001 of https://codereview.chromium.org/2546613004/ ) Reason for revert: IndexError: list index out of range Original issue's description: > Enable hermetic builds for iOS. > > BUG=669094 > > Committed: https://crrev.com/080de20fe53a35ec6b5ce89470261157f9389db3 > Cr-Commit-Position: refs/heads/master@{#437269} TBR=erikchen@chromium.org,kjellander@chromium.org,sdefresne@chromium.org,rsesek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669094 Committed: https://crrev.com/73c24cdb89cee4af2adb7021dbd05d4418525ef8 Cr-Commit-Position: refs/heads/master@{#437273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M build/mac/should_use_hermetic_xcode.py View 2 chunks +2 lines, -7 lines 0 comments Download
M build_overrides/build.gni View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
justincohen
Created Revert of Enable hermetic builds for iOS.
4 years ago (2016-12-08 17:25:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552383006/1
4 years ago (2016-12-08 17:26:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 17:27:16 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-08 17:29:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73c24cdb89cee4af2adb7021dbd05d4418525ef8
Cr-Commit-Position: refs/heads/master@{#437273}

Powered by Google App Engine
This is Rietveld 408576698