third_party/WebKit/Source/modules/presentation/PresentationConnection.h - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.h

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: resolve code review comments from mlamouri Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/presentation/presentationrequest.html ('K') | « third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnection.idl » ('j') | third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.h

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.h b/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

index 323c6a38f42c7c8e9b28cb3241ff5f630d0f2e07..7dab7600344812305e54dd0f8aa02cd3ad774df6 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.h

@@ -56,6 +56,7 @@ class PresentationConnection final : public EventTargetWithInlineData,

DECLARE_VIRTUAL_TRACE();

const String& id() const { return m_id; }

+ const String& url() const { return m_url; }

const WTF::AtomicString& state() const;

void send(const String& message, ExceptionState&);