third_party/WebKit/Source/modules/presentation/PresentationRequest.idl - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: resolve code review comments from foolip Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/presentation/presentation-start.html ('K') | « third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequestTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl b/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

index f7770280924134182fce6c76e90a839043c02200..8e3da63b5a7439b82ca331f556c1c2936a2bc083 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

+++ b/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

@@ -2,13 +2,13 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// TODO(mlamouri): double-check link after spec changes have landed.

// https://w3c.github.io/presentation-api/#interface-presentationrequest

[

ActiveScriptWrappable,

ConstructorCallWith=ExecutionContext,

- Constructor(DOMString url),

+ Constructor(USVString url),

+ Constructor(sequence<USVString> urls),

DependentLifetime,

MeasureAs=PresentationRequestConstructor,

RaisesException=Constructor,