third_party/WebKit/Source/modules/presentation/PresentationConnection.idl - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.idl

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: resolve code review comments from foolip Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/presentation/presentation-start.html ('K') | « third_party/WebKit/Source/modules/presentation/PresentationConnection.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.idl

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.idl b/third_party/WebKit/Source/modules/presentation/PresentationConnection.idl

index 78a6331f83ce10fb9cb6245e4a30d5f94a1f5274..9b6138f04d04680966defe8aac4ec92591292090 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.idl

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.idl

@@ -13,7 +13,8 @@ enum PresentationConnectionState {

[

RuntimeEnabled=Presentation

] interface PresentationConnection : EventTarget {

- readonly attribute DOMString id;

+ readonly attribute USVString id;

+ readonly attribute USVString url;

readonly attribute PresentationConnectionState state;

[MeasureAs=PresentationConnectionClose] void close();

[MeasureAs=PresentationConnectionTerminate] void terminate();