Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: content/renderer/presentation/presentation_dispatcher_unittest.cc

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)
Patch Set: resolve code review comments from foolip Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/presentation/presentation_dispatcher_unittest.cc
diff --git a/content/renderer/presentation/presentation_dispatcher_unittest.cc b/content/renderer/presentation/presentation_dispatcher_unittest.cc
index 9397f852feda403fd7705c88b7a7412e3ec26875..65b3a8979899d814a372736c8bac20a4e1e90911 100644
--- a/content/renderer/presentation/presentation_dispatcher_unittest.cc
+++ b/content/renderer/presentation/presentation_dispatcher_unittest.cc
@@ -47,14 +47,15 @@ namespace content {
class MockPresentationAvailabilityObserver
: public WebPresentationAvailabilityObserver {
public:
- explicit MockPresentationAvailabilityObserver(WebURL url) : url_(url) {}
+ explicit MockPresentationAvailabilityObserver(const WebVector<WebURL>& urls)
+ : urls_(urls) {}
~MockPresentationAvailabilityObserver() override {}
MOCK_METHOD1(availabilityChanged, void(bool is_available));
- const WebURL url() const override { return url_; }
+ const WebVector<WebURL>& urls() const override { return urls_; }
private:
- const WebURL url_;
+ const WebVector<WebURL> urls_;
};
class MockPresentationService : public PresentationService {
@@ -180,7 +181,7 @@ class PresentationDispatcherTest : public ::testing::Test {
urls_(WebVector<WebURL>(gurls_)),
presentation_id_(WebString::fromUTF8("test-id")),
array_buffer_(WebArrayBuffer::create(4, 1)),
- observer_(url1_),
+ observer_(urls_),
dispatcher_(&presentation_service_) {}
~PresentationDispatcherTest() override {}
@@ -373,7 +374,7 @@ TEST_F(PresentationDispatcherTest, TestListenForScreenAvailability) {
base::RunLoop run_loop1;
EXPECT_CALL(presentation_service_, ListenForScreenAvailability(gurl1_));
dispatcher_.getAvailability(
- url1_, base::MakeUnique<WebPresentationAvailabilityCallbacks>());
+ urls_, base::MakeUnique<WebPresentationAvailabilityCallbacks>());
dispatcher_.OnScreenAvailabilityUpdated(url1_, true);
run_loop1.RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698