third_party/WebKit/Source/modules/presentation/PresentationRequest.idl - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/modules/presentation/PresentationConnection.idl ('K') | « third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequestTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl b/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

index f7770280924134182fce6c76e90a839043c02200..48fc1186579dda517a12433d3213ffa9e85e5abe 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

+++ b/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl

@@ -2,13 +2,13 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// TODO(mlamouri): double-check link after spec changes have landed.

-// https://w3c.github.io/presentation-api/#interface-presentationrequest

+// Defined in: https://w3c.github.io/presentation-api/#interface-presentationrequest

foolip 2017/01/11 16:26:10 The "Defined in:" bit isn't needed, the mast major

zhaobin 2017/01/12 00:19:31 Done.

[

ActiveScriptWrappable,

ConstructorCallWith=ExecutionContext,

Constructor(DOMString url),

+ Constructor(DOMString[] urls),

foolip 2017/01/11 16:26:10 Please match https://w3c.github.io/presentation-ap

zhaobin 2017/01/12 00:19:31 Done.

foolip 2017/01/13 20:29:27 Is this also impossible to test because the url do

zhaobin 2017/01/14 00:46:06 Done.

DependentLifetime,

MeasureAs=PresentationRequestConstructor,

RaisesException=Constructor,