[Presentation API] Adds DOMString[] constructor to PresentationRequest.

third_party/WebKit/LayoutTests/presentation/presentationrequest.html

Index: third_party/WebKit/LayoutTests/presentation/presentationrequest.html
diff --git a/third_party/WebKit/LayoutTests/presentation/presentationrequest.html b/third_party/WebKit/LayoutTests/presentation/presentationrequest.html
index c19a84db49bb7044fb7ff1d1c9a2fb49bed5c7ed..2deab2719a33da02fc44dceb8c887b17ce93a691 100644
--- a/third_party/WebKit/LayoutTests/presentation/presentationrequest.html
+++ b/third_party/WebKit/LayoutTests/presentation/presentationrequest.html
@@ -6,22 +6,35 @@
 <script src="../resources/gc.js"></script>
 <script>
 
-async_test(function(t) {
-  var request = new PresentationRequest("http://example.com");
-  request.start().catch(t.step_func(function(e) {
-    assert_true(e instanceof DOMException);
-    assert_equals(e.name, "InvalidAccessError");
-    assert_equals(e.message, "PresentationRequest::start() requires user gesture.");
-    t.done();
-  }));
-}, "Test that the PresentationRequest.start() requires user gesture.")
+var presentationUrl = "http://example.com";
+var presentationUrls = [presentationUrl, "cast://google.com/app_id=deadbeef"];
 
-test(function() {
-  navigator.presentation.defaultRequest = new PresentationRequest("http://example.com");
+var expectedException = new DOMException('PresentationRequest::start() requires user gesture.', 'InvalidAccessError');
+
+promise_test(function(t) {
+  var request = new PresentationRequest(presentationUrl);
+  return promise_rejects(t, expectedException, request.start());
+}, "Test that the PresentationRequest.start() with one URL requires user gesture.")
+
+promise_test(function(t) {
+  var request = new PresentationRequest(presentationUrls);
+  return promise_rejects(t, expectedException, request.start());
+}, "Test that the PresentationRequest.start() with multiple URLs requires user gesture.")
+
+var testGarbageCollection = function(requestArgument) {
+  navigator.presentation.defaultRequest = new PresentationRequest(requestArgument);
   navigator.presentation.defaultRequest.onconnectionavailable = function() {  };
   gc();

[foolip, 2017/01/11 16:26:10]

What object should this GC? The newly created PresentationRequest instance is
reachable and can't be collected.

[zhaobin, 2017/01/12 00:19:31]

It is an existing test. It seems to test that
defaultRequest.onconnectionavailable is still available after gc(). Not sure why
we have this, but there are some similar gc-tests in layout test, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/even....

Leave it as it is since it is not quite related to this CL?

[foolip, 2017/01/13 20:29:27]

You are expanding on the tests here, but if I'm correct the new test isn't
actually testing anything. Maybe ask whoever wrote the test originally what the
intent is?

[zhaobin, 2017/01/14 00:46:06]

Asking mlamouri@.

   assert_not_equals(navigator.presentation.defaultRequest.onconnectionavailable, undefined);
-}, "Test that navigator.presentation.defaultRequest.onconnectionavailable isn't reset after gc()");
+};
+
+test(function() {
+  testGarbageCollection(presentationUrl);
+}, "Test that navigator.presentation.defaultRequest.onconnectionavailable with one URL isn't reset after gc().");
+
+test(function() {
+  testGarbageCollection(presentationUrls);
+}, "Test that navigator.presentation.defaultRequest.onconnectionavailable with multiple URLs isn't reset after gc().");
 
 test(function() {
   var request = new PresentationRequest("http://example.com");