third_party/WebKit/LayoutTests/presentation/presentation-navigation-multipleurls.html - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/presentation/presentation-navigation-multipleurls.html

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: resolve code review comments from mlamouri Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/presentation/presentation_dispatcher.cc ('K') | « third_party/WebKit/LayoutTests/presentation/presentation-api.html ('k') | third_party/WebKit/LayoutTests/presentation/presentationrequest.html » ('j') | third_party/WebKit/LayoutTests/presentation/presentationrequest.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script>

	7

	8 if (location.href.endsWith('#after-reload')) {

	9 test(function() {

	10 assert_equals(navigator.presentation.defaultRequest, null);

	11 }, "Test that navigator.defaultRequest with multiple URLs isn't kept alive aft er reload.")

	12 } else {

	13 navigator.presentation.defaultRequest = new PresentationRequest(["https://exam ple.org", "cast://google.com/app_id=deadbeef"]);
	mlamouri (slow - plz ping) 2016/12/13 13:50:53 What is this testing exactly? The test name says " What is this testing exactly? The test name says "multipleurls" but the actual testing seems to check that reloading reset the `defaultRequest`. zhaobin 2016/12/14 01:51:53 I think we test both navigation and mulitple urls Show quoted text On 2016/12/13 13:50:53, mlamouri wrote: > What is this testing exactly? The test name says "multipleurls" but the actual > testing seems to check that reloading reset the `defaultRequest`. I think we test both navigation and mulitple urls in this test (we use multiple url constructor to create defaultRequest). whywhat 2016/12/14 02:20:39 I think that just adding a ctor test in the presen Show quoted text On 2016/12/14 at 01:51:53, zhaobin wrote: > On 2016/12/13 13:50:53, mlamouri wrote: > > What is this testing exactly? The test name says "multipleurls" but the actual > > testing seems to check that reloading reset the `defaultRequest`. > > I think we test both navigation and mulitple urls in this test (we use multiple url constructor to create defaultRequest). I think that just adding a ctor test in the presentation-api.html is enough for this change. maybe getAvailability could be tested additionally for multiple urls case when not all of them are incompatible or that the connection created by start() has one of the URLs from the list - but that's for the follow up cls and maybe additional test harness built (one can mock Mojo services in LayoutTests now, for instance).
	14

	15 location.href += '#after-reload';

	16 location.reload();

	17 }

	18

	19 </script>

	20 </body>

	21 </html>

OLD	NEW