third_party/WebKit/LayoutTests/presentation/presentation-navigation-multipleurls.html - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/presentation/presentation-navigation-multipleurls.html

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/presentation/presentation-api.html ('K') | « third_party/WebKit/LayoutTests/presentation/presentation-api.html ('k') | third_party/WebKit/LayoutTests/presentation/presentationrequest.html » ('j') | third_party/WebKit/LayoutTests/presentation/presentationrequest.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script>

	7

	8 if (location.href.endsWith('#after-reload')) {

	9 test(function() {

	10 assert_equals(navigator.presentation.defaultRequest, null);

	11 }, "Test that navigator.defaultRequest with multiple URLs isn't kept alive aft er reload.")
	foolip 2017/01/11 16:26:10 Can you move this into an iframe that you navigate Can you move this into an iframe that you navigate? I don't know if this structure of test would work in web-platform-tests. https://github.com/w3c/web-platform-tests/commit/6653d7ac9b1a56e3a712586ea8f0... is an example of such a test. zhaobin 2017/01/12 00:19:31 It affects presentation-navigation.html and presen Show quoted text On 2017/01/11 16:26:10, foolip_slow_very_sorry wrote: > Can you move this into an iframe that you navigate? I don't know if this > structure of test would work in web-platform-tests. > https://github.com/w3c/web-platform-tests/commit/6653d7ac9b1a56e3a712586ea8f0... > is an example of such a test. It affects presentation-navigation.html and presentation-navigation-multipleurls.html. Will fix it in a seperate patch. Created crbug.com/680298. foolip 2017/01/13 20:29:27 Acknowledged. Show quoted text On 2017/01/12 00:19:31, zhaobin wrote: > On 2017/01/11 16:26:10, foolip_slow_very_sorry wrote: > > Can you move this into an iframe that you navigate? I don't know if this > > structure of test would work in web-platform-tests. > > > https://github.com/w3c/web-platform-tests/commit/6653d7ac9b1a56e3a712586ea8f0... > > is an example of such a test. > > It affects presentation-navigation.html and > presentation-navigation-multipleurls.html. Will fix it in a seperate patch. > Created crbug.com/680298. Acknowledged.
	12 } else {

	13 navigator.presentation.defaultRequest = new PresentationRequest(["https://exam ple.org", "cast://google.com/app_id=deadbeef"]);

	14

	15 location.href += '#after-reload';

	16 location.reload();

	17 }

	18

	19 </script>

	20 </body>

	21 </html>

OLD	NEW