third_party/WebKit/LayoutTests/presentation/presentation-api.html - Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest.

Side by Side Diff: third_party/WebKit/LayoutTests/presentation/presentation-api.html

Issue 2552343009: [Presentation API] Adds DOMString[] constructor to PresentationRequest. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/LayoutTests/presentation/presentation-navigation-multipleurls.html » ('j') | third_party/WebKit/LayoutTests/presentation/presentation-navigation-multipleurls.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <script src="../resources/testharness.js"></script>	4 <script src="../resources/testharness.js"></script>

5 <script src="../resources/testharnessreport.js"></script>	5 <script src="../resources/testharnessreport.js"></script>

6 <script>	6 <script>

7	7

8 test(function() {	8 test(function() {

9 assert_true('presentation' in navigator);	9 assert_true('presentation' in navigator);

10 assert_true('defaultRequest' in navigator.presentation);	10 assert_true('defaultRequest' in navigator.presentation);

(...skipping 11 matching lines...) Expand all Loading...
22 }, "Test that navigator.presentation is not an EventTarget.");	22 }, "Test that navigator.presentation is not an EventTarget.");

23	23

24 test(function() {	24 test(function() {

25 var request = new PresentationRequest('foo.html');	25 var request = new PresentationRequest('foo.html');

26 assert_equals(typeof(request.start), "function");	26 assert_equals(typeof(request.start), "function");

27 assert_equals(typeof(request.reconnect), "function");	27 assert_equals(typeof(request.reconnect), "function");

28 assert_equals(typeof(request.getAvailability), "function");	28 assert_equals(typeof(request.getAvailability), "function");

29 assert_equals(typeof(request.onconnectionavailable), "object");	29 assert_equals(typeof(request.onconnectionavailable), "object");

30	30

31 assert_true(request instanceof EventTarget);	31 assert_true(request instanceof EventTarget);

32 }, "Test PresentationRequest API types.");	32 }, "Test PresentationRequest API types for a single URL.");

	33

	34 test(function() {

	35 var request = new PresentationRequest(["http://example.com", "cast://google.co m/app_id=deadbeef"]);

	36 assert_equals(typeof(request.start), "function");

	37 assert_equals(typeof(request.reconnect), "function");

	38 assert_equals(typeof(request.getAvailability), "function");

	39 assert_equals(typeof(request.onconnectionavailable), "object");

	40

	41 assert_true(request instanceof EventTarget);

	42 }, "Test PresentationRequest API types for multiple URLs.");
	foolip 2017/01/11 16:26:10 This test would pass even without the new code I t This test would pass even without the new code I think because the array is stringified to something which can be parsed as a URL. Can you also check request.id? zhaobin 2017/01/12 00:19:31 Yes, this test will pass even without the new code Show quoted text On 2017/01/11 16:26:10, foolip_slow_very_sorry wrote: > This test would pass even without the new code I think because the array is > stringified to something which can be parsed as a URL. Can you also check > request.id? Yes, this test will pass even without the new code. Unfortunately Request does not expose id or url property, so there is no way to check that. foolip 2017/01/13 20:29:27 What does it take to get a PresentationConnection Show quoted text On 2017/01/12 00:19:31, zhaobin wrote: > On 2017/01/11 16:26:10, foolip_slow_very_sorry wrote: > > This test would pass even without the new code I think because the array is > > stringified to something which can be parsed as a URL. Can you also check > > request.id? > > Yes, this test will pass even without the new code. Unfortunately Request does > not expose id or url property, so there is no way to check that. What does it take to get a PresentationConnection which could be used to check this? Are there no tests like this as LayoutTests yet? zhaobin 2017/01/14 00:46:06 Done. Show quoted text On 2017/01/13 20:29:27, foolip_slow_very_sorry wrote: > On 2017/01/12 00:19:31, zhaobin wrote: > > On 2017/01/11 16:26:10, foolip_slow_very_sorry wrote: > > > This test would pass even without the new code I think because the array is > > > stringified to something which can be parsed as a URL. Can you also check > > > request.id? > > > > Yes, this test will pass even without the new code. Unfortunately Request does > > not expose id or url property, so there is no way to check that. > > What does it take to get a PresentationConnection which could be used to check > this? Are there no tests like this as LayoutTests yet? Done.
33	43

34 </script>	44 </script>

35 </body>	45 </body>

36 </html>	46 </html>

OLD	NEW