Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2552343007: MD CrOS Shelf - fix alignment of guest user name in shelf bubble. (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD CrOS Shelf - fix alignment of guest user name in shelf bubble. BUG=672032 TEST=chrome --login-manager --login-profile=user Committed: https://crrev.com/b920332c2a50ff61bd1544ef51c6b3563f0bbdd5 Cr-Commit-Position: refs/heads/master@{#437162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ash/common/system/user/user_card_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Evan Stade
the hardest part was figuring out how to launch guest mode.
4 years ago (2016-12-07 23:13:16 UTC) #2
tdanderson
LGTM
4 years ago (2016-12-08 00:09:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552343007/1
4 years ago (2016-12-08 02:57:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 03:04:56 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 03:07:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b920332c2a50ff61bd1544ef51c6b3563f0bbdd5
Cr-Commit-Position: refs/heads/master@{#437162}

Powered by Google App Engine
This is Rietveld 408576698