[DevTools] clean breakpoints and decorations onUISourceCodeContentChanged

third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 167 matching lines @@
    */
   willHide() {
     super.willHide();
     this._popoverHelper.hidePopover();
   }
 
   /**
    * @override
    */
   onUISourceCodeContentChanged() {
-    for (var decoration of this._breakpointDecorations)
-      decoration.breakpoint.remove();
+    var decorations = Array.from(this._breakpointDecorations);
+    this._textEditor.operation(() => decorations.map(decoration => decoration.hide()));

[lushnikov, 2016/12/07 05:08:40]

Why do we need "hide"? Can't we have just this:

for (var decoration of this._breakpointDecorations.valuesArray()) {
       this._breakpointDecorations.delete(decoration);
       this._updateBreakpointDecoration(decoration);
       if (decoration.breakpoint)
          decoration.breakpoint.remove();
 }

[kozy, 2016/12/07 05:13:15]

You're right. breakpoint.remove will synchronously remove decoration and sync
its update. In update procedures I'll remove all inline decorations since there
is no real breakpoint in line.

+    for (var decoration of decorations) {
+      if (decoration.breakpoint)
+        decoration.breakpoint.remove();
+    }
+    this._breakpointDecorations.clear();
     super.onUISourceCodeContentChanged();
   }
 
   /**
    * @override
    */
   onTextChanged(oldRange, newRange) {
     this._scriptsPanel.updateLastModificationTime();
     super.onTextChanged(oldRange, newRange);
     if (this._compiler)
@@ skipping 1121 matching lines @@
   hide() {
     if (!this.bookmark)
       return;
     this.bookmark.clear();
     this.bookmark = null;
   }
 };
 
 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('bookmark');
 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbol('element');