Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2552283003: Allow Blob image src to be used as MediaNotification artwork (Closed)

Created:
4 years ago by Zhiqiang Zhang (Slow)
Modified:
4 years ago
Reviewers:
whywhat
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, haraken, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow Blob image src to be used as MediaNotification artwork The ImageDownloader actually supports blob: scheme URLs, we should reduce the restriction on MediaImage src to allow blob: URLs to be used. Steps for testing: * Navigate to http://xxyzzzq.github.io/sandbox/media-session/blob-icon-test.html and start playing media. * Click "Choose File" to upload an image. The preferred image can be found at: http://xxyzzzq.github.io/sandbox/media-session/BLOB.png * Observe the media notification. The icon should change. BUG=616411 TEST=Manual Committed: https://crrev.com/b025c5c637cde4d106038868eb5ad170ba168e66 Cr-Commit-Position: refs/heads/master@{#436668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/browser/media/session/media_metadata_sanitizer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Zhiqiang Zhang (Slow)
4 years ago (2016-12-06 15:55:17 UTC) #2
whywhat
lgtm can we have a test of some sort?
4 years ago (2016-12-06 16:43:12 UTC) #3
Zhiqiang Zhang (Slow)
On 2016/12/06 16:43:12, whywhat_OOO_till_Mon_Nov_28 wrote: > lgtm > > can we have a test of ...
4 years ago (2016-12-06 17:34:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552283003/1
4 years ago (2016-12-06 17:35:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 18:57:39 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 19:02:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b025c5c637cde4d106038868eb5ad170ba168e66
Cr-Commit-Position: refs/heads/master@{#436668}

Powered by Google App Engine
This is Rietveld 408576698