Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: components/password_manager/core/browser/statistics_table.h

Issue 2552263002: Pass InteractionStats by value (Closed)
Patch Set: ={} Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/statistics_table.h
diff --git a/components/password_manager/core/browser/statistics_table.h b/components/password_manager/core/browser/statistics_table.h
index eefa3b45a7de835aa9ce6b9723c07ae281e3fa7f..57d707083dbd07292630ba7d11a7e6b4b9ff9e4a 100644
--- a/components/password_manager/core/browser/statistics_table.h
+++ b/components/password_manager/core/browser/statistics_table.h
@@ -41,7 +41,7 @@ bool operator==(const InteractionsStats& lhs, const InteractionsStats& rhs);
// Returns an element from |stats| with |username| or nullptr if not found.
const InteractionsStats* FindStatsByUsername(
- const std::vector<const InteractionsStats*>& stats,
+ const std::vector<InteractionsStats>& stats,
const base::string16& username);
// Represents the 'stats' table in the Login Database.
@@ -70,7 +70,7 @@ class StatisticsTable {
bool RemoveRow(const GURL& domain);
// Returns the statistics for |domain| if it exists.
- std::vector<std::unique_ptr<InteractionsStats>> GetRows(const GURL& domain);
+ std::vector<InteractionsStats> GetRows(const GURL& domain);
// Removes the statistics between the dates. If |origin_filter| is not null,
// only statistics for matching origins are removed. Returns true if the SQL

Powered by Google App Engine
This is Rietveld 408576698