Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2552243002: [wasm][asm.js] Fix errata 5.4, allow fround on int literal.s (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Fix errata 5.4, allow fround on int literal.s asm.js errata on section 5.4 allows fround of numeric literals without '.'. BUG=v8:4203 R=titzer@chromium.org Committed: https://crrev.com/fb7ee44ca1b9acbd68b2cda7bfc5929abba2bbb9 Cr-Commit-Position: refs/heads/master@{#41510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M src/asmjs/asm-typer.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bradn
4 years ago (2016-12-06 10:22:36 UTC) #4
titzer
On 2016/12/06 10:22:36, bradn wrote: lgtm
4 years ago (2016-12-06 10:32:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552243002/1
4 years ago (2016-12-06 10:33:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 10:43:05 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 10:44:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb7ee44ca1b9acbd68b2cda7bfc5929abba2bbb9
Cr-Commit-Position: refs/heads/master@{#41510}

Powered by Google App Engine
This is Rietveld 408576698