Make ifdefs consistent in WebKit/Source/platform

Make ifdefs consistent in WebKit/Source/platform

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
Committed: https://crrev.com/57fbc20f3f7558560780cc44a8b993f4f17d593a
Cr-Commit-Position: refs/heads/master@{#436726}

[Alexander Alekseev, 2016-12-06 09:18:44]

alemate@chromium.org changed reviewers:
+ jochen@chromium.org

[Alexander Alekseev, 2016-12-06 09:18:45]

Please review.

[Alexander Alekseev, 2016-12-06 09:18:52]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 09:19:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-12-06 09:24:34]

lgtm

[commit-bot: I haz the power, 2016-12-06 11:02:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 11:02:35]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-12-06 21:02:48]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:03:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:15:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481058168991400, "parent_rev":
"203ec9093b6648e5665a9497f8de7f2409977fd5", "commit_rev":
"1d9f790de57924af9b3c0e095635537137c05cb9"}

[commit-bot: I haz the power, 2016-12-06 21:16:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 21:19:11]

Description was changed from

==========
Make ifdefs consistent in WebKit/Source/platform

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660
==========

to

==========
Make ifdefs consistent in WebKit/Source/platform

This CL addresses a few problems with #ifdefs:

1) DCHECK requires the presence of variables used in it even if DCHECK_IS_ON()
evaluates to 0. Therefore, if debug variable is defined only when DCHECK_IS_ON()
is true, its usage must be guarded the same way.

2) If debug method in base class is defined only when DCHECK_IS_ON() is true,
its descendants must be guarded with the same check.

BUG=666660

Committed: https://crrev.com/57fbc20f3f7558560780cc44a8b993f4f17d593a
Cr-Commit-Position: refs/heads/master@{#436726}
==========

[commit-bot: I haz the power, 2016-12-06 21:19:12]

Patchset 1 (id:??) landed as
https://crrev.com/57fbc20f3f7558560780cc44a8b993f4f17d593a
Cr-Commit-Position: refs/heads/master@{#436726}