Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4434)

Unified Diff: chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc

Issue 2552223002: Remove explicit singletonness of ArcBridgeService part 2. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
diff --git a/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc b/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
index 81de469a7fa9ea91123e163d9ffc5fd3aa5da7c3..c886e6d07dceab9c86f683567c47b491df05f4c0 100644
--- a/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
+++ b/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
@@ -2,14 +2,17 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <memory>
#include <string>
#include <utility>
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/location.h"
+#include "base/memory/ptr_util.h"
#include "base/threading/thread_task_runner_handle.h"
#include "chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.h"
+#include "components/arc/arc_service_manager.h"
#include "components/arc/test/fake_arc_bridge_service.h"
#include "components/arc/test/fake_file_system_instance.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -80,15 +83,19 @@ class ArcContentFileSystemFileStreamReaderTest : public testing::Test {
base::FilePath path = temp_dir_.GetPath().AppendASCII("bar");
ASSERT_TRUE(base::WriteFile(path, kData, arraysize(kData)));
- file_system_.reset(new ArcFileSystemInstanceTestImpl(path));
+ file_system_ = base::MakeUnique<ArcFileSystemInstanceTestImpl>(path);
- fake_arc_bridge_service_.file_system()->SetInstance(file_system_.get());
+ ArcServiceManager::SetArcBridgeServiceForTesting(
+ base::MakeUnique<FakeArcBridgeService>());
+ arc_service_manager_ = base::MakeUnique<ArcServiceManager>(nullptr);
+ arc_service_manager_->arc_bridge_service()->file_system()->SetInstance(
+ file_system_.get());
}
private:
base::ScopedTempDir temp_dir_;
content::TestBrowserThreadBundle thread_bundle_;
- FakeArcBridgeService fake_arc_bridge_service_;
+ std::unique_ptr<ArcServiceManager> arc_service_manager_;
std::unique_ptr<ArcFileSystemInstanceTestImpl> file_system_;
DISALLOW_COPY_AND_ASSIGN(ArcContentFileSystemFileStreamReaderTest);

Powered by Google App Engine
This is Rietveld 408576698