Public Sessions - prompt the user for pageCapture requests

chrome/browser/extensions/api/page_capture/page_capture_api.h

Index: chrome/browser/extensions/api/page_capture/page_capture_api.h
diff --git a/chrome/browser/extensions/api/page_capture/page_capture_api.h b/chrome/browser/extensions/api/page_capture/page_capture_api.h
index f72ea849c06178aa2a8b4c18110c9abda8d145d6..d867e2a201bb0623ea9700c7a0ccf0f236a9774b 100644
--- a/chrome/browser/extensions/api/page_capture/page_capture_api.h
+++ b/chrome/browser/extensions/api/page_capture/page_capture_api.h
@@ -14,6 +14,10 @@
 #include "chrome/common/extensions/api/page_capture.h"
 #include "storage/browser/blob/shareable_file_reference.h"
 
+#if defined(OS_CHROMEOS)
+#include "extensions/common/permissions/api_permission_set.h"
+#endif
+
 namespace base {
 class FilePath;
 }
@@ -42,6 +46,11 @@ class PageCaptureSaveAsMHTMLFunction : public ChromeAsyncExtensionFunction {
   bool RunAsync() override;
   bool OnMessageReceived(const IPC::Message& message) override;
 
+#if defined(OS_CHROMEOS)
+  // Resolves the API permission request in Public Sessions.
+  void ResolvePermissionRequest(PermissionIDSet allowed_permissions);

[Andrew T Wilson (Slow), 2017/02/07 14:26:51]

This is fine as is - but would declaring this as const PermissionIDSet& provide
any efficiencies (so you can pass by reference with no copies?)

[Ivan Šandrk, 2017/02/07 20:41:32]

Not in the current version - two callsites both make the call with a temporary
which should afaik be std::moved into the function call. I may be wrong.

[Ivan Šandrk, 2017/02/10 12:20:32]

You are actually right, it's better as a const ref. Done.

I wanted to use pass by value so the compiler can do std::move optimizations,
but that's only useful if you need a copy inside the function (AFAIK).

+#endif
+
   // Called on the file thread.
   void CreateTemporaryFile();