Public Sessions - prompt the user for pageCapture requests

chrome/common/pref_names.cc

Index: chrome/common/pref_names.cc
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
index d1e5cbcd317f23006e5da5a78555d76efb0c7bb6..6687fc28b88f01f8838b7489cc0a591686a749e7 100644
--- a/chrome/common/pref_names.cc
+++ b/chrome/common/pref_names.cc
@@ -1902,6 +1902,13 @@ const char kNetworkThrottlingEnabled[] = "net.throttling_enabled";
 // Boolean prefs for the local status of the touchscreen.
 const char kTouchscreenEnabledLocal[] = "events.touch_screen.enabled_local";
 
+// Dictionary saving user choices regarding granted permissions to
+// extensions/apps for usage of APIs. In Public Sessions API usage is restricted
+// to protect the user from a malicious device owner/admin. This dictionary will
+// not be persisted across sessions.
+const char kPublicSessionPermissionsUserChoiceCache[] =
+    "public_session.permissions.user_choice_cache";

[gab, 2017/01/09 20:06:43]

I don't see existing public_session.* prefs. With "permissions." This will
create two levels of JSON nesting for a single item, can an existing root be
re-used?

[Ivan Šandrk, 2017/01/09 20:25:54]

I'll think of something else here. Can I just put everything in one level, ie.
public_session_permissions_user_choice_cache?

[gab, 2017/01/09 20:47:01]

Top-level isn't done often either, maybe extensions.?

[Devlin, 2017/01/09 21:22:41]

You could store this in ExtensionPrefs, which is the extensions layer on top of
the profile prefs and maps to extensions.*.

[Ivan Šandrk, 2017/01/11 17:41:50]

Thanks for the suggestion devlin. I'll keep it this way unless that's better for
some reason I'm unaware of.

I'm also planning on doing a bigger refactoring anyway, so it shouldn't matter
too much.

[Ivan Šandrk, 2017/01/11 17:41:51]

I hope this one sounds ok.

[gab, 2017/01/11 19:13:33]

If that's where all extensions.* prefs are then that's probably better but I'll
defer to devlin on that one since this pref_names.cc already has a few
extensions.* prefs.

+
 #endif  // defined(OS_CHROMEOS)
 
 // Whether there is a Flash version installed that supports clearing LSO data.