Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2552203007: Public Sessions - prompt the user for pageCapture requests (Closed)
Patch Set: Devlin's comments, added other files Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/device_local_account_management_pol icy_provider.h" 5 #include "chrome/browser/chromeos/extensions/device_local_account_management_pol icy_provider.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cstddef> 9 #include <cstddef>
10 #include <string> 10 #include <string>
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 "nativeMessaging", 553 "nativeMessaging",
554 554
555 // Admin controls network connectivity anyways. 555 // Admin controls network connectivity anyways.
556 "networking.config", 556 "networking.config",
557 557
558 // Status quo considers this risky due to the ability to fake system UI - 558 // Status quo considers this risky due to the ability to fake system UI -
559 // low risk IMHO however since notifications are already badged with app 559 // low risk IMHO however since notifications are already badged with app
560 // icon and won't extract any data. 560 // icon and won't extract any data.
561 "notifications", 561 "notifications",
562 562
563 // Captures page content, so block. Alternatively: Allow, but either (1) 563 // User is prompted (allow/deny) when an extension requests pageCapture for
564 // prompt user or (2) return blank content. 564 // the first time in a session. The request is made via
565 // "pageCapture", 565 // chrome.pageCapture.saveAsMHTML call.
566 "pageCapture",
566 567
567 // Allows to use machine crypto keys - these would be provisioned by the 568 // Allows to use machine crypto keys - these would be provisioned by the
568 // admin anyways. 569 // admin anyways.
569 "platformKeys", 570 "platformKeys",
570 571
571 // No plugins on Chrome OS anyways. 572 // No plugins on Chrome OS anyways.
572 "plugin", 573 "plugin",
573 574
574 // Status quo notes concern about UX spoofing - not an issue IMHO. 575 // Status quo notes concern about UX spoofing - not an issue IMHO.
575 "pointerLock", 576 "pointerLock",
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
934 if (error) { 935 if (error) {
935 *error = l10n_util::GetStringFUTF16( 936 *error = l10n_util::GetStringFUTF16(
936 IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT, 937 IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT,
937 base::UTF8ToUTF16(extension->name()), 938 base::UTF8ToUTF16(extension->name()),
938 base::UTF8ToUTF16(extension->id())); 939 base::UTF8ToUTF16(extension->id()));
939 } 940 }
940 return false; 941 return false;
941 } 942 }
942 943
943 } // namespace chromeos 944 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698