Public Sessions - prompt the user for pageCapture requests

chrome/browser/extensions/api/page_capture/page_capture_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_PAGE_CAPTURE_PAGE_CAPTURE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_PAGE_CAPTURE_PAGE_CAPTURE_API_H_
 
 #include <stdint.h>
 
+#include <memory>
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/common/extensions/api/page_capture.h"
+#include "components/prefs/pref_change_registrar.h"
+#include "components/prefs/pref_service.h"
 #include "storage/browser/blob/shareable_file_reference.h"
 
 namespace base {
 class FilePath;
 }
 
 namespace content {
 class WebContents;
 }
 
@@ skipping 24 matching lines @@
   void TemporaryFileCreated(bool success);
   void ReturnFailure(const std::string& error);
   void ReturnSuccess(int64_t file_size);
 
   // Callback called once the MHTML generation is done.
   void MHTMLGenerated(int64_t mhtml_file_size);
 
   // Returns the WebContents we are associated with, NULL if it's been closed.
   content::WebContents* GetWebContents();
 
+  // Handles permission checking inside of Public Sessions.
+  void HandlePermission();
+
+#if defined(OS_CHROMEOS)

[Devlin, 2016/12/12 20:09:37]

This is a fair amount of cros-only code.  I think it would maybe be cleaner if
we pulled this into a public session helper-type object in a file only compiled
on cros, and limited this to

(pseudo-code)

#if defined(cros)
  PageCapturePermissionHelper permission_helper_;
#endif

.cc
#if defined(cros)
  permission_helper_.RequestPermission(base::Bind(&OnPermissionRequested));
#else
  OnPermissionRequested(GRANTED);
#endif

[Ivan Šandrk, 2016/12/13 16:32:47]

That's a good point. Are you fine with me doing a follow up CL to address this?
I was planning anyhow on refactoring the work I've done so far on permissions.

[Devlin, 2016/12/13 21:51:29]

Is there a reason not to do it here?  I don't feel terribly strongly, but have a
slight preference for having them land together.

[Ivan Šandrk, 2017/01/04 17:09:59]

Done.

+  enum PermissionState {
+    NOT_PROMPTED = 0,
+    SHOWN_PROMPT,
+    ALLOWED,
+    DENIED
+  };
+
+  // Sets up the dialog asking the user for permission.
+  void ShowPermissionPrompt();
+
+  // Function used to resolve user decision regarding allowing page capture.

[Devlin, 2016/12/12 20:09:37]

nit: typically, we don't need "Function used to"-type references in the function
comment, because it's clear that it's a function (and presumably will be used).
:)  So here, let's just say something like "Handles the user decision of whether
to allow page capture." or something like that.

[Ivan Šandrk, 2016/12/13 16:32:47]

True, done.

+  void ResolvePermissionPrompt(ExtensionInstallPrompt::Result prompt_result);
+
+  // Helper function that continues with the page capture (if user allowed it),
+  // or returns failure (user denied permission).
+  void ChainRunAsync();

[Devlin, 2016/12/12 20:09:37]

I'm not sure the "ChainRunAsync" name makes sense to me...

[Ivan Šandrk, 2016/12/13 16:32:47]

Does ResolvePermissionRequest sound better?

+
+  PrefService* GetPrefs();
+
+  void UserChoiceSet(PermissionState value);
+  PermissionState UserChoiceGet();
+#endif  // defined(OS_CHROMEOS)
+
   std::unique_ptr<extensions::api::page_capture::SaveAsMHTML::Params> params_;
 
   // The path to the temporary file containing the MHTML data.
   base::FilePath mhtml_path_;
 
   // The file containing the MHTML.
   scoped_refptr<storage::ShareableFileReference> mhtml_file_;
 
+#if defined(OS_CHROMEOS)
+  std::unique_ptr<ExtensionInstallPrompt> prompt_;
+  std::unique_ptr<PrefChangeRegistrar> pref_change_registrar_;
+#endif  // defined(OS_CHROMEOS)
+
   DECLARE_EXTENSION_FUNCTION("pageCapture.saveAsMHTML", PAGECAPTURE_SAVEASMHTML)
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_PAGE_CAPTURE_PAGE_CAPTURE_API_H_