Issue 2552203006: Fuchsia: Reland enable observatory. Pass rpath for host builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2552203006: Fuchsia: Reland enable observatory. Pass rpath for host builds. (Closed)

Created:
4 years ago by zra

Modified:
4 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org, phosek

Target Ref:
refs/heads/master

Visibility:
Public.

Fuchsia: Reland enable observatory. Pass rpath for host builds. Fuchsia host build boilerplate doesn't setup rpath the same way that the standalone build does, so we pass the flags explicitly when building dart executables. Committed: https://github.com/dart-lang/sdk/commit/f4b7952ae0d20b38f1bc0041dd5a9b6164ffe795

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -30 lines)			Patch
	M	runtime/bin/BUILD.gn	View	1	2 chunks	+38 lines, -29 lines	0 comments	Download
	M	runtime/observatory/BUILD.gn	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (2 generated)

zra

4 years ago (2016-12-08 07:14:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f4b7952ae0d20b38f1bc0041dd5a9b6164ffe795 (presubmit successful).