Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2552163002: Fix crash when referencing a registered non-inherited custom property (Closed)

Created:
4 years ago by Timothy Loh
Modified:
4 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when referencing a registered non-inherited custom property This patch fixes a crash that occurs when a registered non-inherited custom property is referenced on an element which doesn't explicitly have any registered non-inherited custom properties set. The code was missing a null-check for the non-inherited custom properties object. Note that elsewhere in the file this is not needed as the object is guaranteed to exist when we are resolving such properties. BUG=671484 Committed: https://crrev.com/1bf1f4ca99b8ea3183c9aa358338e63d5de07b93 Cr-Commit-Position: refs/heads/master@{#436880}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/custom-properties/registered-property-initial.html View 1 chunk +23 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
Timothy Loh
https://codereview.chromium.org/2552163002/diff/1/third_party/WebKit/LayoutTests/custom-properties/registered-property-initial.html File third_party/WebKit/LayoutTests/custom-properties/registered-property-initial.html (right): https://codereview.chromium.org/2552163002/diff/1/third_party/WebKit/LayoutTests/custom-properties/registered-property-initial.html#newcode17 third_party/WebKit/LayoutTests/custom-properties/registered-property-initial.html:17: assert_equals(computedStyle.getPropertyValue('--inherited-color'), 'pink'); The discrepancy pink vs rgb().. is tracked ...
4 years ago (2016-12-06 05:11:27 UTC) #4
alancutter (OOO until 2018)
lgtm
4 years ago (2016-12-06 05:34:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552163002/1
4 years ago (2016-12-06 05:43:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/348430)
4 years ago (2016-12-06 06:23:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552163002/1
4 years ago (2016-12-07 00:48:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/351196)
4 years ago (2016-12-07 03:52:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552163002/1
4 years ago (2016-12-07 03:55:02 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 06:45:49 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-07 06:48:14 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bf1f4ca99b8ea3183c9aa358338e63d5de07b93
Cr-Commit-Position: refs/heads/master@{#436880}

Powered by Google App Engine
This is Rietveld 408576698