Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 2552153002: [BlobStorage] Enabling disk paging and direct storage. (Closed)
Patch Set: added comments to WebContentsImplTest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index bd092ddf53310a7b9c44ecbd81c0ebc19430f28a..06882efb143a168f1808795da9e63c392d6f1ac8 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -827,6 +827,9 @@ TEST_F(WebContentsImplTest, NavigateFromSitelessUrl) {
DeleteContents();
EXPECT_EQ(orig_rvh_delete_count, 1);
EXPECT_EQ(pending_rvh_delete_count, 1);
+ // Since the ChromeBlobStorageContext posts a task to the BrowserThread, we
+ // must run out the loop so the thread bundle is destroyed after this happens.
+ base::RunLoop().RunUntilIdle();
}
// Regression test for http://crbug.com/386542 - variation of
@@ -874,6 +877,9 @@ TEST_F(WebContentsImplTest, NavigateFromRestoredSitelessUrl) {
// Cleanup.
DeleteContents();
+ // Since the ChromeBlobStorageContext posts a task to the BrowserThread, we
+ // must run out the loop so the thread bundle is destroyed after this happens.
+ base::RunLoop().RunUntilIdle();
}
// Complement for NavigateFromRestoredSitelessUrl, verifying that when a regular
@@ -919,6 +925,9 @@ TEST_F(WebContentsImplTest, NavigateFromRestoredRegularUrl) {
// Cleanup.
DeleteContents();
+ // Since the ChromeBlobStorageContext posts a task to the BrowserThread, we
+ // must run out the loop so the thread bundle is destroyed after this happens.
+ base::RunLoop().RunUntilIdle();
}
// Test that we can find an opener RVH even if it's pending.
« no previous file with comments | « content/browser/blob_storage/chrome_blob_storage_context.cc ('k') | storage/browser/blob/blob_memory_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698