Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2552143002: Refactor Nearby Message listener (Closed)

Created:
4 years ago by cco3
Modified:
4 years ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor Nearby Message listener Instead of putting the Nearby Message listener directly in the IntentService, we place it in the PhysicalWebBleClient so that we can override it with other versions of the listener. BUG=671400 Committed: https://crrev.com/05eaec60267085699bc11943ff9c6a87be3f6039 Cr-Commit-Position: refs/heads/master@{#436826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyMessageIntentService.java View 1 chunk +2 lines, -17 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
cco3
4 years ago (2016-12-06 00:38:50 UTC) #2
mattreynolds
lgtm
4 years ago (2016-12-06 01:54:27 UTC) #3
cco3
4 years ago (2016-12-06 18:33:35 UTC) #5
nyquist
lgtm
4 years ago (2016-12-07 00:57:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552143002/1
4 years ago (2016-12-07 01:05:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 01:39:10 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 01:42:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05eaec60267085699bc11943ff9c6a87be3f6039
Cr-Commit-Position: refs/heads/master@{#436826}

Powered by Google App Engine
This is Rietveld 408576698