Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2552123003: Update jsshell to 50.0 (Closed)

Created:
4 years ago by Harry Terkelsen
Modified:
4 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tests/corelib/corelib.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/firefox_jsshell/README.google View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/firefox_jsshell/linux/jsshell.tar.gz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/firefox_jsshell/mac/jsshell.tar.gz.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/firefox_jsshell/win/jsshell.tar.gz.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Harry Terkelsen
4 years ago (2016-12-06 23:15:29 UTC) #2
Harry Terkelsen
4 years ago (2016-12-07 00:55:10 UTC) #4
sra1
lgtm
4 years ago (2016-12-07 00:57:46 UTC) #5
Harry Terkelsen
4 years ago (2016-12-07 00:58:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c78814326c349938ed7183a986a0c1900df31978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698