Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Issue 2552113004: Enable GPU raster for AMD R2-R4 and Windows 8.1 (Closed)

Created:
4 years ago by ericrk
Modified:
4 years ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable GPU raster for AMD R2-R4 and Windows 8.1 Expanding the whitelist to include R2-R4 GPUs. This class of GPU performed well in manual testing. IDs from: http://developer.amd.com/resources/ati-catalyst-pc-vendor-id-1002-li/ Also expanded from Win 10 to Win 8.1 for Intel/AMD (NVidia was already enabled for 8.1). R=jbauman BUG=646135 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a62538cb478ded1cf711050a1670304bf26d7ef4 Cr-Commit-Position: refs/heads/master@{#436995}

Patch Set 1 #

Patch Set 2 : formatting #

Total comments: 2

Patch Set 3 : Increment version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -28 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 4 chunks +16 lines, -28 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
ericrk
Pushing out the whitelist a bit more in Canary. https://codereview.chromium.org/2552113004/diff/20001/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/2552113004/diff/20001/gpu/config/software_rendering_list_json.cc#newcode1323 gpu/config/software_rendering_list_json.cc:1323: ...
4 years ago (2016-12-06 22:09:36 UTC) #2
jbauman
lgtm https://codereview.chromium.org/2552113004/diff/20001/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/2552113004/diff/20001/gpu/config/software_rendering_list_json.cc#newcode21 gpu/config/software_rendering_list_json.cc:21: "version": "12.04", Make sure to update the version.
4 years ago (2016-12-06 22:11:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552113004/40001
4 years ago (2016-12-06 22:15:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
4 years ago (2016-12-07 00:18:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552113004/40001
4 years ago (2016-12-07 17:34:53 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-07 17:43:41 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-07 17:45:35 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a62538cb478ded1cf711050a1670304bf26d7ef4
Cr-Commit-Position: refs/heads/master@{#436995}

Powered by Google App Engine
This is Rietveld 408576698