Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 2552113003: [ObjC ARC] Converts ios/chrome/browser/reading_list:reading_list to ARC.Automatically generated A… (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
Reviewers:
Olivier
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/reading_list:reading_list to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/70a6daac38c18092b7d1b4b07bda9e1adf54f2a5 Cr-Commit-Position: refs/heads/master@{#436943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/reading_list/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_entry_loading_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_web_state_observer.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL
4 years ago (2016-12-06 17:30:05 UTC) #4
Olivier
lgtm
4 years ago (2016-12-06 17:32:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552113003/1
4 years ago (2016-12-07 14:16:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 14:21:22 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 14:23:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70a6daac38c18092b7d1b4b07bda9e1adf54f2a5
Cr-Commit-Position: refs/heads/master@{#436943}

Powered by Google App Engine
This is Rietveld 408576698