Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 255203002: Implement end-preview flow with views (Closed)

Created:
6 years, 7 months ago by guohui
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1

Patch Set 2 : typo fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -22 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +12 lines, -0 lines 0 comments Download
chrome/app/google_chrome_strings.grd View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 4 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.h View 1 6 chunks +30 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 17 chunks +113 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
guohui
Hey, could you please review the CL? sky@ for owner review of chrome\browser\ui\views\... noms@ and ...
6 years, 7 months ago (2014-04-29 15:51:49 UTC) #1
sky
LGTM - I really hope we don't go with what is shown in that slide ...
6 years, 7 months ago (2014-04-29 17:22:59 UTC) #2
noms (inactive)
lgtm
6 years, 7 months ago (2014-04-29 17:34:41 UTC) #3
guohui
On 2014/04/29 17:22:59, sky wrote: > LGTM - I really hope we don't go with ...
6 years, 7 months ago (2014-04-29 18:03:02 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/255203002/diff/20001/chrome/browser/ui/views/profiles/profile_chooser_view.h File chrome/browser/ui/views/profiles/profile_chooser_view.h (right): https://codereview.chromium.org/255203002/diff/20001/chrome/browser/ui/views/profiles/profile_chooser_view.h#newcode252 chrome/browser/ui/views/profiles/profile_chooser_view.h:252: // The current tutoria mode. Typo: tutorial
6 years, 7 months ago (2014-04-29 18:09:36 UTC) #5
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 7 months ago (2014-04-29 18:35:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/255203002/40001
6 years, 7 months ago (2014-04-29 18:36:08 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:11:10 UTC) #8
Message was sent while issue was closed.
Change committed as 267080

Powered by Google App Engine
This is Rietveld 408576698