Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2551973005: [heap] Clear cached wrappers upon aborting incremental marking (Closed)

Created:
4 years ago by Michael Lippautz
Modified:
4 years ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Clear cached wrappers upon aborting incremental marking BUG=chromium:468240, chromium:668060 Committed: https://crrev.com/fd127502092b3d6d8ccce7c33d63c4f46178ce43 Cr-Commit-Position: refs/heads/master@{#41553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Michael Lippautz
PTAL I will try to cleanup the messy usage of EmbedderHeapTracer from all over heap/ ...
4 years ago (2016-12-07 13:30:38 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-07 13:31:26 UTC) #6
Marcel Hlopko
lgtm
4 years ago (2016-12-07 13:35:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551973005/1
4 years ago (2016-12-07 14:02:11 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 14:04:15 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd127502092b3d6d8ccce7c33d63c4f46178ce43 Cr-Commit-Position: refs/heads/master@{#41553}
4 years ago (2016-12-07 14:04:45 UTC) #17
haraken
4 years ago (2016-12-07 14:37:29 UTC) #18
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698