Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2551973003: Use correct document for notifying of inserted import. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews, tfarina, dglazkov+blink, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct document for notifying of inserted import. Notify the root document to update active stylesheets. If the import child contains stylesheets, the StyleEngine for the import document will be notified correctly. Added a couple of sanity DCHECKs. R=meade@chromium.org BUG=671322 Committed: https://crrev.com/8c3cb689223aefc7f9d620f318016ea0a28485da Cr-Commit-Position: refs/heads/master@{#436887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/html/imports/import-child-null-document-crash.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rune
ptal
4 years ago (2016-12-06 09:46:50 UTC) #2
meade_UTC10
lgtm
4 years ago (2016-12-07 05:10:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551973003/1
4 years ago (2016-12-07 07:21:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 07:25:50 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-07 07:28:10 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c3cb689223aefc7f9d620f318016ea0a28485da
Cr-Commit-Position: refs/heads/master@{#436887}

Powered by Google App Engine
This is Rietveld 408576698