Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2551973002: DevTools: fix overlapping toolbars in Sources and SearchableViews (Closed)

Created:
4 years ago by luoe
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix overlapping toolbars in Sources and SearchableViews Please see bugs for screenshots of the change. With this CL, the search bar will be on top of the Quick Source's tabbed pane of files, and the Sources status toolbar will be on top of the search bar. BUG=612692, 660305 Committed: https://crrev.com/9171632e16a5bc03d40755ae559e5aa236199db1 Cr-Commit-Position: refs/heads/master@{#436469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/sourcesView.css View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/searchableView.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
luoe
This CL affects all SearchableViews. I manually checked as many as I could find. Please ...
4 years ago (2016-12-05 19:53:51 UTC) #3
lushnikov
lgtm
4 years ago (2016-12-05 20:29:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551973002/1
4 years ago (2016-12-06 00:11:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 00:17:57 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-06 00:20:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9171632e16a5bc03d40755ae559e5aa236199db1
Cr-Commit-Position: refs/heads/master@{#436469}

Powered by Google App Engine
This is Rietveld 408576698