Reland of Paint collapsed borders of a table as one display item

Reland of Paint collapsed borders of a table as one display item (patchset #1 id:1 of https://codereview.chromium.org/2556633002/ )

Reason for revert:
This revert seems to have broken paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html  and virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html on many bots. Reverting some more just to be on the safe side.

See for example https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/516

Original issue's description:
> Revert of Paint collapsed borders of a table as one display item (patchset #4 id:60001 of https://codereview.chromium.org/2502353003/ )
>
> Reason for revert:
> Need to think more about performance and improve.
>
> Original issue's description:
> > Paint collapsed borders of a table as one display item
> >
> > This simplifies paint invalidation logic on collapsed border changes.
> >
> > About performance:
> > With this CL we create a big display item on the table containing all
> > collapsed border paintings, instead of many small display items on cells.
> > This will cause more painting when the display item is invalidated, but
> > saves time to handle many cached display items. Perf try jobs [1] show
> > that this CL improves performance of one test
> > (blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
> > and degrade performance of one test
> > (blink_perf.paint.large-table-repaint.html)
> > and doesn't affect much of performance of other tests.
> > Cluster-telemetry run showed no change or slight progression (https://ct.skia.org/chromium_perf_runs/, run 1433)
> >
> > This is a reland of https://codereview.chromium.org/2430313004, with
> > crbug.com/664887 fixed by force invalidation of collapsed borders on
> > layout change.
> >
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > BUG=663208, 664887
> > TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with changed display item types about collapsed borders)
> >
> > Review-Url: https://codereview.chromium.org/2430313004
> > Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e
> > Cr-Original-Commit-Position: refs/heads/master@{#431744}
> > Cr-Commit-Position: refs/heads/master@{#436426}
>
> TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=663208, 664887
>
> Committed: https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c
> Cr-Commit-Position: refs/heads/master@{#436484}

TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663208, 664887
Committed: https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca
Cr-Commit-Position: refs/heads/master@{#436521}

[Adam Rice, 2016-12-06 04:25:17]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-12-06 04:25:18]

Created Reland of Paint collapsed borders of a table as one display item

[commit-bot: I haz the power, 2016-12-06 04:25:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 04:28:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480998317656670, "parent_rev":
"3cc4adea8fd24bb687ab5c48e6a6521381810a84", "commit_rev":
"a1a55ce8c2c6fd43850c651e6fd1178c01150294"}

[commit-bot: I haz the power, 2016-12-06 04:29:13]

Description was changed from

==========
Reland of Paint collapsed borders of a table as one display item (patchset #1
id:1 of https://codereview.chromium.org/2556633002/ )

Reason for revert:
This revert seems to have broken
paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html 
and
virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html
on many bots. Reverting some more just to be on the safe side.

See for example
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trust...

Original issue's description:
> Revert of Paint collapsed borders of a table as one display item (patchset #4
id:60001 of https://codereview.chromium.org/2502353003/ )
> 
> Reason for revert:
> Need to think more about performance and improve.
> 
> Original issue's description:
> > Paint collapsed borders of a table as one display item
> >
> > This simplifies paint invalidation logic on collapsed border changes.
> >
> > About performance:
> > With this CL we create a big display item on the table containing all
> > collapsed border paintings, instead of many small display items on cells.
> > This will cause more painting when the display item is invalidated, but
> > saves time to handle many cached display items. Perf try jobs [1] show
> > that this CL improves performance of one test
> >
(blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
> > and degrade performance of one test
> > (blink_perf.paint.large-table-repaint.html)
> > and doesn't affect much of performance of other tests.
> > Cluster-telemetry run showed no change or slight progression
(https://ct.skia.org/chromium_perf_runs/, run 1433)
> >
> > This is a reland of https://codereview.chromium.org/2430313004, with
> > crbug.com/664887 fixed by force invalidation of collapsed borders on
> > layout change.
> >
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > BUG=663208,664887
> > TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with
changed display item types about collapsed borders)
> >
> > Review-Url: https://codereview.chromium.org/2430313004
> > Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e
> > Cr-Original-Commit-Position: refs/heads/master@{#431744}
> > Cr-Commit-Position: refs/heads/master@{#436426}
> 
> TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=663208,664887
> 
> Committed: https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c
> Cr-Commit-Position: refs/heads/master@{#436484}

TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org,wangxianz...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663208,664887
==========

to

==========
Reland of Paint collapsed borders of a table as one display item (patchset #1
id:1 of https://codereview.chromium.org/2556633002/ )

Reason for revert:
This revert seems to have broken
paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html 
and
virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html
on many bots. Reverting some more just to be on the safe side.

See for example
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trust...

Original issue's description:
> Revert of Paint collapsed borders of a table as one display item (patchset #4
id:60001 of https://codereview.chromium.org/2502353003/ )
> 
> Reason for revert:
> Need to think more about performance and improve.
> 
> Original issue's description:
> > Paint collapsed borders of a table as one display item
> >
> > This simplifies paint invalidation logic on collapsed border changes.
> >
> > About performance:
> > With this CL we create a big display item on the table containing all
> > collapsed border paintings, instead of many small display items on cells.
> > This will cause more painting when the display item is invalidated, but
> > saves time to handle many cached display items. Perf try jobs [1] show
> > that this CL improves performance of one test
> >
(blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
> > and degrade performance of one test
> > (blink_perf.paint.large-table-repaint.html)
> > and doesn't affect much of performance of other tests.
> > Cluster-telemetry run showed no change or slight progression
(https://ct.skia.org/chromium_perf_runs/, run 1433)
> >
> > This is a reland of https://codereview.chromium.org/2430313004, with
> > crbug.com/664887 fixed by force invalidation of collapsed borders on
> > layout change.
> >
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > BUG=663208,664887
> > TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with
changed display item types about collapsed borders)
> >
> > Review-Url: https://codereview.chromium.org/2430313004
> > Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e
> > Cr-Original-Commit-Position: refs/heads/master@{#431744}
> > Cr-Commit-Position: refs/heads/master@{#436426}
> 
> TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=663208,664887
> 
> Committed: https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c
> Cr-Commit-Position: refs/heads/master@{#436484}

TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org,wangxianz...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663208,664887
==========

[commit-bot: I haz the power, 2016-12-06 04:29:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 04:31:19]

Description was changed from

==========
Reland of Paint collapsed borders of a table as one display item (patchset #1
id:1 of https://codereview.chromium.org/2556633002/ )

Reason for revert:
This revert seems to have broken
paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html 
and
virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html
on many bots. Reverting some more just to be on the safe side.

See for example
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trust...

Original issue's description:
> Revert of Paint collapsed borders of a table as one display item (patchset #4
id:60001 of https://codereview.chromium.org/2502353003/ )
> 
> Reason for revert:
> Need to think more about performance and improve.
> 
> Original issue's description:
> > Paint collapsed borders of a table as one display item
> >
> > This simplifies paint invalidation logic on collapsed border changes.
> >
> > About performance:
> > With this CL we create a big display item on the table containing all
> > collapsed border paintings, instead of many small display items on cells.
> > This will cause more painting when the display item is invalidated, but
> > saves time to handle many cached display items. Perf try jobs [1] show
> > that this CL improves performance of one test
> >
(blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
> > and degrade performance of one test
> > (blink_perf.paint.large-table-repaint.html)
> > and doesn't affect much of performance of other tests.
> > Cluster-telemetry run showed no change or slight progression
(https://ct.skia.org/chromium_perf_runs/, run 1433)
> >
> > This is a reland of https://codereview.chromium.org/2430313004, with
> > crbug.com/664887 fixed by force invalidation of collapsed borders on
> > layout change.
> >
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > BUG=663208,664887
> > TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with
changed display item types about collapsed borders)
> >
> > Review-Url: https://codereview.chromium.org/2430313004
> > Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e
> > Cr-Original-Commit-Position: refs/heads/master@{#431744}
> > Cr-Commit-Position: refs/heads/master@{#436426}
> 
> TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=663208,664887
> 
> Committed: https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c
> Cr-Commit-Position: refs/heads/master@{#436484}

TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org,wangxianz...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663208,664887
==========

to

==========
Reland of Paint collapsed borders of a table as one display item (patchset #1
id:1 of https://codereview.chromium.org/2556633002/ )

Reason for revert:
This revert seems to have broken
paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html 
and
virtual/spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html
on many bots. Reverting some more just to be on the safe side.

See for example
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trust...

Original issue's description:
> Revert of Paint collapsed borders of a table as one display item (patchset #4
id:60001 of https://codereview.chromium.org/2502353003/ )
>
> Reason for revert:
> Need to think more about performance and improve.
>
> Original issue's description:
> > Paint collapsed borders of a table as one display item
> >
> > This simplifies paint invalidation logic on collapsed border changes.
> >
> > About performance:
> > With this CL we create a big display item on the table containing all
> > collapsed border paintings, instead of many small display items on cells.
> > This will cause more painting when the display item is invalidated, but
> > saves time to handle many cached display items. Perf try jobs [1] show
> > that this CL improves performance of one test
> >
(blink_perf.paint.large-table-background-change-with-visible-collapsed-borders.html),
> > and degrade performance of one test
> > (blink_perf.paint.large-table-repaint.html)
> > and doesn't affect much of performance of other tests.
> > Cluster-telemetry run showed no change or slight progression
(https://ct.skia.org/chromium_perf_runs/, run 1433)
> >
> > This is a reland of https://codereview.chromium.org/2430313004, with
> > crbug.com/664887 fixed by force invalidation of collapsed borders on
> > layout change.
> >
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > BUG=663208,664887
> > TBR=chrishtr@chromium.org (for platform/graphics/paint/DisplayItem.h with
changed display item types about collapsed borders)
> >
> > Review-Url: https://codereview.chromium.org/2430313004
> > Committed: https://crrev.com/16363da3f8fba57bef3d203bbb8590bf4f60037e
> > Cr-Original-Commit-Position: refs/heads/master@{#431744}
> > Cr-Commit-Position: refs/heads/master@{#436426}
>
> TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=663208,664887
>
> Committed: https://crrev.com/6c06fc0cfddfb60ae2ab0bb1ca88b2428db70c7c
> Cr-Commit-Position: refs/heads/master@{#436484}

TBR=chrishtr@chromium.org,wkorman@chromium.org,esprehn@chromium.org,wangxianz...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=663208,664887

Committed: https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca
Cr-Commit-Position: refs/heads/master@{#436521}
==========

[commit-bot: I haz the power, 2016-12-06 04:31:20]

Patchset 1 (id:??) landed as
https://crrev.com/0f3a24a75d753be1d151dcb825b349218acf34ca
Cr-Commit-Position: refs/heads/master@{#436521}

[Adam Rice, 2016-12-06 09:01:41]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2548333003/ by ricea@chromium.org.

The reason for reverting is: Tests break when this patch is out, but more break
when it's in. Reverting again..