Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2551963002: media: Rename media_mojo_shell_unittests to media_service_unittests (Closed)

Created:
4 years ago by xhwang
Modified:
4 years ago
Reviewers:
jam, alokp
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Rename media_mojo_shell_unittests to media_service_unittests TBR=jam@chromium.org BUG=656112 TEST=No functionality change Committed: https://crrev.com/9c958fd2553179870953b398506678a5e1319714 Cr-Commit-Position: refs/heads/master@{#436442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -236 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
D media/mojo/services/media_mojo_unittest.cc View 1 chunk +0 lines, -221 lines 0 comments Download
A + media/mojo/services/media_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/test_manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/determinism/deterministic_build_whitelist.pyl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
xhwang
PTAL
4 years ago (2016-12-05 19:32:20 UTC) #4
alokp
lgtm
4 years ago (2016-12-05 22:15:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551963002/1
4 years ago (2016-12-05 22:16:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/318846)
4 years ago (2016-12-05 22:25:56 UTC) #10
xhwang
TBRing jam@ on this renaming only CL.
4 years ago (2016-12-05 22:29:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551963002/1
4 years ago (2016-12-05 22:30:49 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 23:17:50 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-05 23:20:03 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c958fd2553179870953b398506678a5e1319714
Cr-Commit-Position: refs/heads/master@{#436442}

Powered by Google App Engine
This is Rietveld 408576698