Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2551943003: Fix crash in --print-scopes when Scope::variables_ is empty (Closed)

Created:
4 years ago by adamk
Modified:
4 years ago
Reviewers:
neis, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix crash in --print-scopes when Scope::variables_ is empty Apparently our HashMap can't deal with iteration over an empty map. R=verwaest@chromium.org,neis@chromium.org BUG=v8:5711 Committed: https://crrev.com/1f53653e6cd3e80a5e75723748bbd2c2647f8886 Cr-Commit-Position: refs/heads/master@{#41535}

Patch Set 1 #

Patch Set 2 : Simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/ast/scopes.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
4 years ago (2016-12-05 19:43:36 UTC) #1
neis
lgtm
4 years ago (2016-12-06 10:28:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551943003/20001
4 years ago (2016-12-06 18:34:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 19:16:18 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-06 19:16:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f53653e6cd3e80a5e75723748bbd2c2647f8886
Cr-Commit-Position: refs/heads/master@{#41535}

Powered by Google App Engine
This is Rietveld 408576698