Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 255193002: [CSS Shapes] complex calc args for inset round vanish (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, ojan, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] complex calc args for inset round vanish In order to use calc in the rounded parameters for inset shapes, we need to pass RenderStyle for the value creation as we did for the width arguments. Without taking RenderStyle into account, we hit an assert not reached in CSSPrimitiveValue::init in the debug builds. This is a merge of http://trac.webkit.org/changeset/167936 by Zoltan Horvath <zoltan@webkit.org>;. BUG=367889 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172938

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unneeded one parameter LengthSize version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/shapes/parsing/parsing-test-utils.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Zoltan
https://codereview.chromium.org/255193002/diff/1/Source/core/css/CSSPrimitiveValue.h File Source/core/css/CSSPrimitiveValue.h (right): https://codereview.chromium.org/255193002/diff/1/Source/core/css/CSSPrimitiveValue.h#newcode390 Source/core/css/CSSPrimitiveValue.h:390: CSSPrimitiveValue(const LengthSize&, const RenderStyle&); Is the one parameter LengthSize ...
6 years, 7 months ago (2014-04-29 21:43:24 UTC) #1
rwlbuis
On 2014/04/29 21:43:24, Zoltan wrote: > https://codereview.chromium.org/255193002/diff/1/Source/core/css/CSSPrimitiveValue.h > File Source/core/css/CSSPrimitiveValue.h (right): > > https://codereview.chromium.org/255193002/diff/1/Source/core/css/CSSPrimitiveValue.h#newcode390 > ...
6 years, 7 months ago (2014-04-29 22:24:49 UTC) #2
rwlbuis
PTAL @leviw, another straightforward patch. Thankfully we still have only one variant for LengthSize.
6 years, 7 months ago (2014-04-29 22:26:06 UTC) #3
leviw_travelin_and_unemployed
LGTM!
6 years, 7 months ago (2014-04-29 22:30:29 UTC) #4
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 7 months ago (2014-04-29 22:30:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/255193002/20001
6 years, 7 months ago (2014-04-29 22:31:59 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:05:12 UTC) #7
Message was sent while issue was closed.
Change committed as 172938

Powered by Google App Engine
This is Rietveld 408576698